Page MenuHomePhabricator

Unbundle & package seperately utils/jsonparser
Closed, ResolvedPublic

Description

So it can be used by other scripts like the test wiki inactive admins one.

  • Add to PyPi account
  • Create GitHub repo
  • Replace usages in MHBP

Details

Security
None

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedRhinosF1
OpenNone
OpenNone
ResolvedNone
ResolvedRhinosF1
ResolvedMacFan4000
OpenMacFan4000
ResolvedMacFan4000
OpenNone
OpenNone
ResolvedMacFan4000
OpenNone
OpenNone
OpenRhinosF1
OpenRhinosF1
OpenRhinosF1
OpenNone
OpenRhinosF1
OpenNone
OpenRhinosF1
ResolvedRhinosF1
ResolvedRhinosF1
ResolvedRhinosF1
ResolvedMacFan4000

Event Timeline

RhinosF1 created this task.

https://pypi.org/project/MirahezeBots-jsonparser/1.0.0/ - new releases are published on the python 3.7 travis check and only when tagged on GitHub.

After much frustration, the packaging is fully done, and there is an open PR against the dev branch on the MirahezeBots repo.

After much frustration, the packaging is fully done, and there is an open PR against the dev branch on the MirahezeBots repo.

Fustration, I'll document stuff and ensure travis and other CI checks all match with the main repo

https://pypi.org/project/MirahezeBots-jsonparser/1.0.0/ - new releases are published on the python 3.7 travis check and only when tagged on GitHub.

We don't do on tags. We just do on master builds for py3.7

I wonder if we may also want to do the same with mwapihandler and expand it.

In T87#1472, @RhinosF1 wrote:

We also don't ever use future

If you are referring to https://github.com/MirahezeBots/jsonparser/blob/master/setup.py#L2, that’s a direct copy/paste from MirahezeBots/MirahezeBots

Also I used the name MirahezeBots_jsonparser because jsonparser was taken

In T87#1472, @RhinosF1 wrote:

We also don't ever use future

If you are referring to https://github.com/MirahezeBots/jsonparser/blob/master/setup.py#L2, that’s a direct copy/paste from MirahezeBots/MirahezeBots

That needs fixing

Also I used the name MirahezeBots_jsonparser because jsonparser was taken

https://pypi.org/project/jsonfiletodict/ is literal and free. We should probably split both functions into a single file for each.

Removing assign again as I did a bunch of the work.

RhinosF1 assigned this task to MacFan4000.

This task is done, I've merged your PR.

Will check anything hasn't gone itchy tonight and announce a plan I was talking to Zppix and Doug about.